Bug 112722

Summary: Merge MainResourceLoader's SubstituteData loading + others into DocumentLoader
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, hausmann, jturcotte, kadam, koivisto, ossy, rniwa, webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104969, 112811    
Attachments:
Description Flags
patch
none
Fix compile error none

Nate Chapin
Reported 2013-03-19 11:27:22 PDT
Others include: * MainResourceLoader's error handling into DocumentLoader::mainReceivedError() * MainResourceLoader::cancel into DocumentLoader::cancelMainResourceLoad * m_identifierForLoadWithoutResourceLoader handling, plus remaining synthesized ResourceLoadNotifier callbacks.
Attachments
patch (21.66 KB, patch)
2013-03-19 11:36 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
Fix compile error (21.68 KB, patch)
2013-03-19 11:48 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2013-03-19 11:36:39 PDT
Created attachment 193878 [details] patch
Nate Chapin
Comment 2 2013-03-19 11:48:23 PDT
Created attachment 193885 [details] Fix compile error
Antti Koivisto
Comment 3 2013-03-19 12:02:54 PDT
Comment on attachment 193885 [details] Fix compile error r=me
WebKit Review Bot
Comment 4 2013-03-19 12:42:06 PDT
Comment on attachment 193885 [details] Fix compile error Clearing flags on attachment: 193885 Committed r146239: <http://trac.webkit.org/changeset/146239>
WebKit Review Bot
Comment 5 2013-03-19 12:42:10 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 6 2013-03-19 13:09:39 PDT
Mac build fix landed in http://trac.webkit.org/changeset/146242.
Csaba Osztrogonác
Comment 7 2013-03-19 16:59:49 PDT
(In reply to comment #4) > (From update of attachment 193885 [details]) > Clearing flags on attachment: 193885 > > Committed r146239: <http://trac.webkit.org/changeset/146239> It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194 cc-ing Qt folks for investigation
Alexey Proskuryakov
Comment 8 2013-03-20 09:43:34 PDT
This also caused bug 112811.
Nate Chapin
Comment 9 2013-03-21 08:34:25 PDT
(In reply to comment #7) > (In reply to comment #4) > > (From update of attachment 193885 [details] [details]) > > Clearing flags on attachment: 193885 > > > > Committed r146239: <http://trac.webkit.org/changeset/146239> > > It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194 > > cc-ing Qt folks for investigation Are these tests still crashing? I'd be happy to help diagnose if you have a stack trace.
Csaba Osztrogonác
Comment 10 2013-03-21 08:40:16 PDT
(In reply to comment #9) > > It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194 > > > > cc-ing Qt folks for investigation > > Are these tests still crashing? I'd be happy to help diagnose if you have a stack trace. No, the crashes went away somewhere between r146261-r146283.
Nate Chapin
Comment 11 2013-03-21 08:49:00 PDT
(In reply to comment #10) > (In reply to comment #9) > > > It made 60 tests crash on Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28194 > > > > > > cc-ing Qt folks for investigation > > > > Are these tests still crashing? I'd be happy to help diagnose if you have a stack trace. > > No, the crashes went away somewhere between r146261-r146283. Ah, yeah, I fixed a bunch of chromium asserts in http://trac.webkit.org/changeset/146267, which probably had the same root issue. Thanks!
Note You need to log in before you can comment on or make changes to this bug.