Summary: | Web Inspector: Remove remainings of CSS-based console message filtering. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Zvorygin <zvorygin> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED INVALID | ||||||||||||
Severity: | Normal | CC: | apavlov, buildbot, burg, dglazkov, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | 113321 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Dmitry Zvorygin
2013-03-19 10:05:27 PDT
Created attachment 193863 [details]
Patch
Comment on attachment 193863 [details] Patch Attachment 193863 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17179373 New failing tests: inspector/console/console-preserve-log.html Comment on attachment 193863 [details] Patch Attachment 193863 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17238280 New failing tests: inspector/console/console-preserve-log.html Comment on attachment 193863 [details] Patch Attachment 193863 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17215640 New failing tests: inspector/console/console-preserve-log.html Comment on attachment 193863 [details] Patch Attachment 193863 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17235203 New failing tests: inspector/console/console-preserve-log.html Comment on attachment 193863 [details]
Patch
r- for the tests failure
Created attachment 193998 [details]
Patch
Fixed broken test. Comment on attachment 193998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193998&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:-274 > - if (target.hasStyleClass("selected")) { Why did this change? > Source/WebCore/inspector/front-end/ConsoleView.js:-288 > - if (!selectMultiple) { This seems to ruin the diff. Can you leave existing condition nesting? > Source/WebCore/inspector/front-end/ConsoleView.js:539 > + return (!message.url || !this._messageURLFilters[message.url]) && (!message.level || this._messageLevelFilters.indexOf(message.level) != -1); This might get a bit expensive - consider using an object for faster lookup. > Source/WebCore/inspector/front-end/ConsoleView.js:774 > + * @param wasThrown You should specify types for parameters and list them in proper order. Created attachment 194264 [details]
Patch
Comment on attachment 194264 [details]
Patch
I'd like to test it manually before landing.
Created attachment 195093 [details]
Patch
Comment on attachment 195093 [details] Patch Clearing flags on attachment: 195093 Committed r146901: <http://trac.webkit.org/changeset/146901> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 113321 |