Bug 112687

Summary: [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, jinwoo7.song, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sudarsana Nagineni (babu)
Reported 2013-03-19 06:12:36 PDT
SearchBar at the bottom of the window should not be visible by default when MiniBrowser opened.
Attachments
Patch (1.13 KB, patch)
2013-03-19 07:30 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2013-03-19 07:30:08 PDT
Created attachment 193824 [details] Patch
Chris Dumez
Comment 2 2013-03-19 07:34:18 PDT
Comment on attachment 193824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review > Tools/MiniBrowser/efl/main.c:1475 > + search_box_hide(window); Does it still work if we move this line before the evas_object_show(window->elm_window) one?
Sudarsana Nagineni (babu)
Comment 3 2013-03-19 07:38:28 PDT
Comment on attachment 193824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review >> Tools/MiniBrowser/efl/main.c:1475 >> + search_box_hide(window); > > Does it still work if we move this line before the evas_object_show(window->elm_window) one? No. I tried already :)
Mikhail Pozdnyakov
Comment 4 2013-03-19 08:00:15 PDT
Comment on attachment 193824 [details] Patch LGTM :)
Chris Dumez
Comment 5 2013-03-19 08:01:00 PDT
Comment on attachment 193824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review >>> Tools/MiniBrowser/efl/main.c:1475 >>> + search_box_hide(window); >> >> Does it still work if we move this line before the evas_object_show(window->elm_window) one? > > No. I tried already :) Ok, then LGTM :)
Jinwoo Song
Comment 6 2013-03-19 16:55:35 PDT
LGTM. Thanks, I missed it. :)
WebKit Review Bot
Comment 7 2013-03-20 05:28:45 PDT
Comment on attachment 193824 [details] Patch Clearing flags on attachment: 193824 Committed r146332: <http://trac.webkit.org/changeset/146332>
WebKit Review Bot
Comment 8 2013-03-20 05:28:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.