Bug 112628 – Implement CanvasRenderingContext2DSettings.alpha for 2d canvas getContext

• Component: New Bugs
• Status: NEW

[Stephen White]

Implement canvas.getContext('2d', { alpha: none })

[Stephen White]

Created attachment 193658 [details]
Patch

[Stephen White]

This is not marked for review, since the feature is under discussion.

[Stephen White]

Created attachment 194676 [details]
Patch

[Stephen White]

Created attachment 194683 [details]
Patch

[WebKit Review Bot]

Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17141604

[WebKit Review Bot]

Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17303008

[Peter Beverloo (cr-android ews)]

Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17292087

[Build Bot]

Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17293150

[WebKit Review Bot]

Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17298094

[WebKit Review Bot]

Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17298096

[Peter Beverloo (cr-android ews)]

Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17141623

[Stephen White]

Created attachment 194692 [details]
Patch

[Elliott Sprehn]

This really needs to be opaque: true. I mean we're even calling it isOpaque in our own code! The test is opaque-....html and so on. Clearly the naming is wrong if we're not using it ourselves.

[Stephen White]

(In reply to comment #13)
> This really needs to be opaque: true. I mean we're even calling it isOpaque in our own code! The test is opaque-....html and so on. Clearly the naming is wrong if we're not using it ourselves.

That's mostly due to it being a modification of the other patch (<canvas opaque>).  The naming here is intended to match WebGL.  Will rename the code while we discuss it.

[Stephen White]

Created attachment 194887 [details]
Patch

[WebKit Review Bot]

Comment on attachment 194887 [details]
Patch

Attachment 194887 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17203597

New failing tests:
canvas/philip/tests/2d.composite.uncovered.nocontext.source-out.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.basic.nocontext.html
canvas/philip/tests/2d.composite.uncovered.nocontext.source-in.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.source-out.html
canvas/philip/tests/2d.composite.uncovered.nocontext.destination-in.html
canvas/philip/tests/2d.composite.uncovered.nocontext.copy.html
canvas/philip/tests/2d.pattern.basic.nocontext.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/image-load-overflow-scrollbars.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-in.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-atop.html
platform/chromium/virtual/softwarecompositing/overflow/image-load-overflow-scrollbars.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.source-in.html
canvas/philip/tests/2d.composite.uncovered.nocontext.destination-atop.html
compositing/overflow/image-load-overflow-scrollbars.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.copy.html

[WebKit Review Bot]

Created attachment 194965 [details]
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Stephen White]

Created attachment 196497 [details]
Patch

[Brent Fulgham]

Dean, is this something we should be looking at for Canvas? This is some old code, so perhaps it's not relevant anymore?

[Sam Weinig]

*** Bug 225191 has been marked as a duplicate of this bug. ***

[Sam Sneddon [:gsnedders]]

Bug 225173 implemented basic support for CanvasRenderingContext2DSettings. Since then, more has been filled in.

We currently have in https://github.com/WebKit/WebKit/blob/9a322f4ab7cee3a527f4df4f1dccf1a9050e9296/Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl with the spec https://html.spec.whatwg.org/multipage/canvas.html#canvasrenderingcontext2dsettings we're missing:

 * alpha, and
 * colorType (which we support as pixelType, see bug 287139).

Let's clarify the title of this bug and make it clear that — like the patch from 2013 — this is entirely about alpha, and that's not merely an example of an attribute.

[Radar WebKit Bug Importer]

<rdar://problem/151891530>