Summary: | [CSS Exclusions] shape outside segments not properly calculated for ellipses | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||||
Component: | CSS | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | eric, esprehn+autocc, jchaffraix, ojan.autocc, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
URL: | http://dev.w3.org/csswg/css3-exclusions/#floats-and-exclusions | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 98664 | ||||||||||||
Attachments: |
|
Created attachment 195605 [details]
Expanded test case
The problem occurs for all Exclusion shapes and only occurs when the shape's logicalTop is non-zero, which causes the float's bounds to be adjusted. The new test case demos the problem for circle, ellipse, and polygon.
Created attachment 195667 [details]
Patch
Fix coordinate calculation
Comment on attachment 195667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195667&action=review > LayoutTests/ChangeLog:14 > + in the right place, we just want to simulate the shape's effect. I would see that as a comment in the code as it's useful to understand the testing code. Created attachment 195789 [details]
Patch
Add requested comment
Comment on attachment 195789 [details] Patch Clearing flags on attachment: 195789 Committed r147250: <http://trac.webkit.org/changeset/147250> All reviewed patches have been landed. Closing bug. |
Created attachment 193587 [details] Example of the bug With some ellipses, the segment value is too short, allowing text to intrude into the shape.