Bug 112587

Summary: [CSS Exclusions] shape outside segments not properly calculated for ellipses
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, jchaffraix, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css3-exclusions/#floats-and-exclusions
Bug Depends on:    
Bug Blocks: 98664    
Attachments:
Description Flags
Example of the bug
none
Expanded test case
none
Patch
jchaffraix: review+
Patch none

Bem Jones-Bey
Reported 2013-03-18 09:56:07 PDT
Created attachment 193587 [details] Example of the bug With some ellipses, the segment value is too short, allowing text to intrude into the shape.
Attachments
Example of the bug (1.36 KB, text/html)
2013-03-18 09:56 PDT, Bem Jones-Bey 		no flags
Details
Expanded test case (2.38 KB, text/html)
2013-03-28 11:26 PDT, Hans Muller 		no flags
Details
Patch (10.44 KB, patch)
2013-03-28 16:07 PDT, Bem Jones-Bey 		jchaffraix: review+
DetailsFormatted DiffDiff
Patch (10.66 KB, patch)
2013-03-29 13:38 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-03-28 11:26:01 PDT
Created attachment 195605 [details] Expanded test case The problem occurs for all Exclusion shapes and only occurs when the shape's logicalTop is non-zero, which causes the float's bounds to be adjusted. The new test case demos the problem for circle, ellipse, and polygon.
Bem Jones-Bey
Comment 2 2013-03-28 16:07:08 PDT
Created attachment 195667 [details] Patch Fix coordinate calculation
Julien Chaffraix
Comment 3 2013-03-29 13:28:30 PDT
Comment on attachment 195667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195667&action=review > LayoutTests/ChangeLog:14 > + in the right place, we just want to simulate the shape's effect. I would see that as a comment in the code as it's useful to understand the testing code.
Bem Jones-Bey
Comment 4 2013-03-29 13:38:54 PDT
Created attachment 195789 [details] Patch Add requested comment
WebKit Review Bot
Comment 5 2013-03-29 14:11:19 PDT
Comment on attachment 195789 [details] Patch Clearing flags on attachment: 195789 Committed r147250: <http://trac.webkit.org/changeset/147250>
WebKit Review Bot
Comment 6 2013-03-29 14:11:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.