Bug 112574

Summary:

[CSS Grid Layout] Fix StyleGridData::operator==

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Layout and Rendering

Assignee:

Julien Chaffraix <jchaffraix>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, esprehn+autocc, hans, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

60731, 112501

Attachments:

Description	Flags
Trivial fix + test.	none

Description Julien Chaffraix 2013-03-18 08:41:10 PDT

Super obvious bug:

bool operator==(const StyleGridData& o) const
{
    return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows && m_gridAutoFlow != o.m_gridAutoFlow;
}

Comment 1 Julien Chaffraix 2013-03-18 09:07:31 PDT

Created attachment 193575 [details]
Trivial fix + test.

Comment 2 Julien Chaffraix 2013-03-18 11:47:55 PDT

Comment on attachment 193575 [details]
Trivial fix + test.

Mac passed the EWS, not sure why it's being picked again for testing.

Comment 3 WebKit Review Bot 2013-03-18 12:06:59 PDT

Comment on attachment 193575 [details]
Trivial fix + test.

Clearing flags on attachment: 193575

Committed r146098: <http://trac.webkit.org/changeset/146098>

Comment 4 WebKit Review Bot 2013-03-18 12:07:03 PDT

All reviewed patches have been landed.  Closing bug.