Bug 112574 - [CSS Grid Layout] Fix StyleGridData::operator==
Summary: [CSS Grid Layout] Fix StyleGridData::operator==
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 60731 112501
  Show dependency treegraph
 
Reported: 2013-03-18 08:41 PDT by Julien Chaffraix
Modified: 2013-03-18 12:07 PDT (History)
8 users (show)

See Also:


Attachments
Trivial fix + test. (4.96 KB, patch)
2013-03-18 09:07 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2013-03-18 08:41:10 PDT
Super obvious bug:

bool operator==(const StyleGridData& o) const
{
    return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows && m_gridAutoFlow != o.m_gridAutoFlow;
}
Comment 1 Julien Chaffraix 2013-03-18 09:07:31 PDT
Created attachment 193575 [details]
Trivial fix + test.
Comment 2 Julien Chaffraix 2013-03-18 11:47:55 PDT
Comment on attachment 193575 [details]
Trivial fix + test.

Mac passed the EWS, not sure why it's being picked again for testing.
Comment 3 WebKit Review Bot 2013-03-18 12:06:59 PDT
Comment on attachment 193575 [details]
Trivial fix + test.

Clearing flags on attachment: 193575

Committed r146098: <http://trac.webkit.org/changeset/146098>
Comment 4 WebKit Review Bot 2013-03-18 12:07:03 PDT
All reviewed patches have been landed.  Closing bug.