Bug 112565

Summary: [GTK] Add padding to all public class structs for future expansion without breaking ABI
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, gustavo, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Carlos Garcia Campos
Reported 2013-03-18 06:53:37 PDT
I think we can use 4 pointers for most of the classes that are unlikely to grow and 8 for WebKitWebView and WebKitWebContext.
Attachments
Patch (20.25 KB, patch)
2013-03-18 06:55 PDT, Carlos Garcia Campos 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-03-18 06:55:31 PDT
Created attachment 193551 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-03-18 07:55:04 PDT
Comment on attachment 193551 [details] Patch Sounds good to me
Carlos Garcia Campos
Comment 3 2013-05-15 02:16:03 PDT
I had forgotten this patch. It's very important to land this before making the first unstable release. Please, owners, this should be trivial to review and has already been approved by Gustavo.
Carlos Garcia Campos
Comment 4 2013-05-15 11:11:02 PDT
Committed r150130: <http://trac.webkit.org/changeset/150130>
Note You need to log in before you can comment on or make changes to this bug.