Bug 112563

Summary:

HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar

Product:

WebKit

Reporter:

Allan Sandfeld Jensen <allan.jensen>

Component:

UI Events

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, esprehn+autocc, ojan.autocc, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Allan Sandfeld Jensen 2013-03-18 06:17:58 PDT

To preserve original behavior HitTestRequest::AllowFrameScrollbars only tested the scrollbars of child frame when introduced. This is however both confusing and unnecessary. The one remaining call site using the options also needs to hit test the main frame, and is currently forced to do that after a hit-test with HitTestRequest::AllowFrameScrollbars.

Comment 1 Allan Sandfeld Jensen 2013-03-18 06:22:13 PDT

Created attachment 193547 [details]
Patch

Comment 2 Antonio Gomes 2013-04-10 10:40:30 PDT

Comment on attachment 193547 [details]
Patch

Looks good. Could we use mock scrollbars to add some basic tests?

Comment 3 Allan Sandfeld Jensen 2013-04-10 11:24:33 PDT

(In reply to comment #2)
> (From update of attachment 193547 [details])
> Looks good. Could we use mock scrollbars to add some basic tests?

At this point it is just a refactoring and already covered by existing tests.

Comment 4 Allan Sandfeld Jensen 2013-04-11 02:16:07 PDT

Comment on attachment 193547 [details]
Patch

Clearing flags on attachment: 193547

Committed r148188: <http://trac.webkit.org/changeset/148188>

Comment 5 Allan Sandfeld Jensen 2013-04-11 02:16:12 PDT

All reviewed patches have been landed.  Closing bug.