Bug 112547

Summary:

[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

111729

Attachments:

Description	Flags
Patch	none

Description Alberto Garcia 2013-03-18 02:58:59 PDT

frame->ownerElement() already returns an Element*, so the toElement()
call is unnecessary and breaks the build because of this code in
Element.h:

  // This will catch anyone doing an unnecessary cast.
  void toElement(const Element*);

This changed in r145818:

http://trac.webkit.org/changeset/145818/trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp

Comment 1 Alberto Garcia 2013-03-18 02:59:51 PDT

Created attachment 193510 [details]
Patch

Comment 2 Antonio Gomes 2013-03-18 03:49:05 PDT

Comment on attachment 193510 [details]
Patch

This file should just be completely removed at some point.

Comment 3 WebKit Review Bot 2013-03-18 03:54:41 PDT

Comment on attachment 193510 [details]
Patch

Clearing flags on attachment: 193510

Committed r146051: <http://trac.webkit.org/changeset/146051>

Comment 4 WebKit Review Bot 2013-03-18 03:54:44 PDT

All reviewed patches have been landed.  Closing bug.