Bug 112547

Summary:

[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Alberto Garcia

Reported 2013-03-18 02:58:59 PDT

frame->ownerElement() already returns an Element*, so the toElement() call is unnecessary and breaks the build because of this code in Element.h: // This will catch anyone doing an unnecessary cast. void toElement(const Element*); This changed in r145818: http://trac.webkit.org/changeset/145818/trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp

Attachments
Patch (1.43 KB, patch) 2013-03-18 02:59 PDT, Alberto Garcia	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alberto Garcia

Comment 1 2013-03-18 02:59:51 PDT

Antonio Gomes

Comment 2 2013-03-18 03:49:05 PDT

Comment on attachment 193510 [details] Patch This file should just be completely removed at some point.

WebKit Review Bot

Comment 3 2013-03-18 03:54:41 PDT

WebKit Review Bot

Comment 4 2013-03-18 03:54:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.