Bug 112545

Summary: Web Inspector: [Settings] Register "?" shortcut.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Eugene Klyuchnikov
Reported 2013-03-18 02:43:26 PDT
"?" (show shortcuts page) is not mentioned on shortcuts page.
Attachments
Patch (2.27 KB, patch)
2013-03-18 02:46 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2013-03-18 07:30 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (2.72 KB, patch)
2013-03-18 07:41 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (2.72 KB, patch)
2013-03-18 07:47 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-18 02:46:37 PDT
Created attachment 193509 [details] Patch
Vsevolod Vlasov
Comment 2 2013-03-18 07:06:40 PDT
Comment on attachment 193509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193509&action=review > Source/WebCore/inspector/front-end/inspector.js:704 > + section.addKey(shortcut.makeDescriptor("?"), WebInspector.UIString("Show this page")); Show keyboard shortcuts help
Vsevolod Vlasov
Comment 3 2013-03-18 07:07:23 PDT
Comment on attachment 193509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193509&action=review >> Source/WebCore/inspector/front-end/inspector.js:704 >> + section.addKey(shortcut.makeDescriptor("?"), WebInspector.UIString("Show this page")); > > Show keyboard shortcuts help Please note that F1 also shows this help page.
Eugene Klyuchnikov
Comment 4 2013-03-18 07:30:52 PDT
Created attachment 193558 [details] Patch
Eugene Klyuchnikov
Comment 5 2013-03-18 07:41:04 PDT
Created attachment 193561 [details] Patch
Eugene Klyuchnikov
Comment 6 2013-03-18 07:41:35 PDT
Comment on attachment 193509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193509&action=review >>> Source/WebCore/inspector/front-end/inspector.js:704 >>> + section.addKey(shortcut.makeDescriptor("?"), WebInspector.UIString("Show this page")); >> >> Show keyboard shortcuts help > > Please note that F1 also shows this help page. OK Done.
Vsevolod Vlasov
Comment 7 2013-03-18 07:45:31 PDT
Comment on attachment 193561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193561&action=review > Source/WebCore/inspector/front-end/inspector.js:-678 > - var keys = [ 'var' should be here, not below.
Eugene Klyuchnikov
Comment 8 2013-03-18 07:47:12 PDT
Created attachment 193563 [details] Patch
Eugene Klyuchnikov
Comment 9 2013-03-18 07:49:48 PDT
Comment on attachment 193561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193561&action=review >> Source/WebCore/inspector/front-end/inspector.js:-678 >> - var keys = [ > > 'var' should be here, not below. surely. it is above =)
WebKit Review Bot
Comment 10 2013-03-18 08:13:33 PDT
Comment on attachment 193563 [details] Patch Clearing flags on attachment: 193563 Committed r146066: <http://trac.webkit.org/changeset/146066>
WebKit Review Bot
Comment 11 2013-03-18 08:13:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.