Bug 112527

Summary: INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
Product: WebKit Reporter: Kunihiko Sakamoto <ksakamoto>
Component: FormsAssignee: Kunihiko Sakamoto <ksakamoto>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ojan.autocc, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: All   
Attachments:
Description Flags
Patch none

Kunihiko Sakamoto
Reported 2013-03-17 18:22:56 PDT
Use min/max attributes of <input type=time> and <input type=datetime-local> to limit values selectable by step-up/down. This is the last piece of the series of changes.
Attachments
Patch (47.65 KB, patch)
2013-03-17 18:46 PDT, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kunihiko Sakamoto
Comment 1 2013-03-17 18:46:08 PDT
Created attachment 193476 [details] Patch
Kent Tamura
Comment 2 2013-03-17 22:14:07 PDT
Comment on attachment 193476 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193476&action=review > Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:67 > -DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document, FieldOwner& fieldOwner, int minimum, int maximum, const String& placeholder, const DateTimeNumericFieldElement::Parameters& parameters) > +DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document, FieldOwner& fieldOwner, const Range& range, const Range& hardLimits, const String& placeholder, const DateTimeNumericFieldElement::Parameters& parameters) > : DateTimeFieldElement(document, fieldOwner) > , m_lastDigitCharTime(0) > , m_placeholder(placeholder) > - , m_range(minimum, maximum) > + , m_range(range) > + , m_hardLimits(hardLimits) nit: We should have made this change before this bug to minimize the size of each patches.
WebKit Review Bot
Comment 3 2013-03-17 22:28:30 PDT
Comment on attachment 193476 [details] Patch Clearing flags on attachment: 193476 Committed r146032: <http://trac.webkit.org/changeset/146032>
WebKit Review Bot
Comment 4 2013-03-17 22:28:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.