Bug 112513

Summary: [WK2] Build warning in didReceiveMessage() generated by messages.py
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit2Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP (Temporary Fix)
none
Patch none

Description Gyuyoung Kim 2013-03-17 00:50:35 PDT
There are too many build warning when didReceiveMessage() is generated. *connection* parameter is added though some didReceiveMessage() don't use it.


[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebMediaCacheManagerProxyMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNotificationManagerProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNotificationManagerProxyMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebResourceCacheManagerProxyMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebProcessMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp:44:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp:81:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebApplicationCacheManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/CoordinatedLayerTreeHostProxyMessageReceiver.cpp:46:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/AuthenticationManagerMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebBatteryManagerMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebCookieManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebBatteryManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebFullScreenManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebCookieManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebGeolocationManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebInspectorProxyMessageReceiver.cpp:40:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebInspectorProxyMessageReceiver.cpp:83:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebIconDatabaseProxyMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebMediaCacheManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/AuthenticationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNetworkInfoManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebApplicationCacheManagerMessageReceiver.cpp:36:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNotificationManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebGeolocationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessConnectionMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebIconDatabaseProxyMessageReceiver.cpp:35:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessConnectionManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebMediaCacheManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNetworkInfoManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebResourceCacheManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNotificationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/StorageAreaProxyMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebKeyValueStorageManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/PluginProcessConnectionManagerMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebDatabaseManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/StorageAreaProxyMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/DrawingAreaMessageReceiver.cpp.o
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/EventDispatcherMessageReceiver.cpp.o
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebInspectorMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebDatabaseManagerMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
Comment 1 Zan Dobersek 2013-03-20 03:34:40 PDT
Do you still see these warnings?
Comment 2 Gyuyoung Kim 2013-04-01 21:29:01 PDT
(In reply to comment #1)
> Do you still see these warnings?

Yes, this warnings are still being shown. Are you interested in this bug ?
Comment 3 Gyuyoung Kim 2013-04-08 01:11:30 PDT
Created attachment 196837 [details]
WIP (Temporary Fix)
Comment 4 Gyuyoung Kim 2013-04-08 21:32:41 PDT
CC'ing Anders, I wonder whether this patch can be accepted, could you give your comment ?
Comment 5 Anders Carlsson 2013-04-09 09:34:01 PDT
Looks like a good fix. Legacy receivers are ultimately going away anyway.
Comment 6 Gyuyoung Kim 2013-04-09 22:35:41 PDT
Created attachment 197208 [details]
Patch
Comment 7 Gyuyoung Kim 2013-04-09 22:40:35 PDT
(In reply to comment #5)
> Looks like a good fix. Legacy receivers are ultimately going away anyway.

Thank you for your comment. I request review. Could you review this ?
Comment 8 WebKit Commit Bot 2013-04-10 20:22:01 PDT
Comment on attachment 197208 [details]
Patch

Clearing flags on attachment: 197208

Committed r148169: <http://trac.webkit.org/changeset/148169>
Comment 9 WebKit Commit Bot 2013-04-10 20:22:03 PDT
All reviewed patches have been landed.  Closing bug.