Bug 112513 – [WK2] Build warning in didReceiveMessage() generated by messages.py

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gyuyoung Kim]

There are too many build warning when didReceiveMessage() is generated. *connection* parameter is added though some didReceiveMessage() don't use it.


[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebMediaCacheManagerProxyMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNotificationManagerProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNotificationManagerProxyMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebResourceCacheManagerProxyMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebProcessMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp:44:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp:81:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebApplicationCacheManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/CoordinatedLayerTreeHostProxyMessageReceiver.cpp:46:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/AuthenticationManagerMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebBatteryManagerMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebCookieManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebBatteryManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebFullScreenManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebCookieManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebGeolocationManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebInspectorProxyMessageReceiver.cpp:40:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebInspectorProxyMessageReceiver.cpp:83:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebIconDatabaseProxyMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebMediaCacheManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/AuthenticationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNetworkInfoManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebApplicationCacheManagerMessageReceiver.cpp:36:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNotificationManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebGeolocationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessConnectionMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebIconDatabaseProxyMessageReceiver.cpp:35:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessConnectionManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebMediaCacheManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProxyMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNetworkInfoManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebResourceCacheManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNotificationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/StorageAreaProxyMessageReceiver.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebKeyValueStorageManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/PluginProcessConnectionManagerMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebDatabaseManagerMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/StorageAreaProxyMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/DrawingAreaMessageReceiver.cpp.o
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/EventDispatcherMessageReceiver.cpp.o
[ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebInspectorMessageReceiver.cpp.o
/home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebDatabaseManagerMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter]

[Zan Dobersek]

Do you still see these warnings?

[Gyuyoung Kim]

(In reply to comment #1)
> Do you still see these warnings?

Yes, this warnings are still being shown. Are you interested in this bug ?

[Gyuyoung Kim]

Created attachment 196837 [details]
WIP (Temporary Fix)

[Gyuyoung Kim]

CC'ing Anders, I wonder whether this patch can be accepted, could you give your comment ?

[Anders Carlsson]

Looks like a good fix. Legacy receivers are ultimately going away anyway.

[Gyuyoung Kim]

Created attachment 197208 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #5)
> Looks like a good fix. Legacy receivers are ultimately going away anyway.

Thank you for your comment. I request review. Could you review this ?

[WebKit Commit Bot]

Comment on attachment 197208 [details]
Patch

Clearing flags on attachment: 197208

Committed r148169: <http://trac.webkit.org/changeset/148169>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.