Summary: | Modernize fast/events/autoscroll.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adele, darin, gyuyoung.kim, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Benjamin Poulain
2013-03-16 17:57:58 PDT
Created attachment 193450 [details]
Patch
Comment on attachment 193450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193450&action=review Looks good! Small nit, which may not be worth picking: > LayoutTests/fast/events/no-scroll-on-input-text-selection.html:29 > + var h = ta.offsetTop - document.body.scrollTop + 10; > + eventSender.dragMode = false; > + eventSender.mouseMoveTo(20, h); > + eventSender.mouseDown(); > + eventSender.mouseMoveTo(20, h); > + eventSender.mouseMoveTo(100, h); Nit: these all seem a little magic numbery. There is some code in LayoutTests/media/media-controls.js to find the mid-point of a specified control. That may be useful here for this selection test. Created attachment 196711 [details]
Patch
Comment on attachment 196711 [details] Patch Clearing flags on attachment: 196711 Committed r147830: <http://trac.webkit.org/changeset/147830> All reviewed patches have been landed. Closing bug. |