Bug 112508 – Modernize fast/events/autoscroll.html

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

Modernize fast/events/autoscroll.html

[Benjamin Poulain]

Created attachment 193450 [details]
Patch

[Jer Noble]

Comment on attachment 193450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193450&action=review

Looks good!  Small nit, which may not be worth picking:

> LayoutTests/fast/events/no-scroll-on-input-text-selection.html:29
> +                    var h = ta.offsetTop - document.body.scrollTop + 10;
> +                    eventSender.dragMode = false;
> +                    eventSender.mouseMoveTo(20, h);
> +                    eventSender.mouseDown();
> +                    eventSender.mouseMoveTo(20, h);
> +                    eventSender.mouseMoveTo(100, h);

Nit: these all seem a little magic numbery.  There is some code in LayoutTests/media/media-controls.js to find the mid-point of a specified control.  That may be useful here for this selection test.

[Benjamin Poulain]

Created attachment 196711 [details]
Patch

[Benjamin Poulain]

Comment on attachment 196711 [details]
Patch

Clearing flags on attachment: 196711

Committed r147830: <http://trac.webkit.org/changeset/147830>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.