Bug 112496

Summary:

Web Inspector: Flame Chart. Provide Overview pane for better user expirience

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

112814

Attachments:

Description	Flags
Patch	none
screenshot with overview grid and curtains	none
Patch	none
new screenshot	none
Patch	yurys: review+

Ilya Tikhonovsky

Reported 2013-03-16 02:49:09 PDT

EOM

Attachments
Patch (6.72 KB, patch) 2013-03-16 02:59 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
screenshot with overview grid and curtains (127.82 KB, image/png) 2013-03-16 03:08 PDT, Ilya Tikhonovsky	no flags	Details
Patch (15.91 KB, patch) 2013-03-20 08:22 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
new screenshot (64.71 KB, image/png) 2013-03-20 08:24 PDT, Ilya Tikhonovsky	no flags	Details
Patch (15.24 KB, patch) 2013-03-20 08:53 PDT, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2013-03-16 02:59:46 PDT

Created attachment 193433 [details] Patch

Ilya Tikhonovsky

Comment 2 2013-03-16 03:08:13 PDT

Created attachment 193434 [details] screenshot with overview grid and curtains

Ilya Tikhonovsky

Comment 3 2013-03-16 03:12:45 PDT

Looks like need to have overview grid on top of the chart and second grid on bottom. Otherwise it might confuse the web developer. I'll do that in the next patch.

Pavel Feldman

Comment 4 2013-03-16 03:24:10 PDT

Comment on attachment 193433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193433&action=review > Source/WebCore/inspector/front-end/FlameChart.js:442 > + this._overviewTimelineGrid.element.style.width = this._overviewContainer.clientHeight; width = height? > Source/WebCore/inspector/front-end/FlameChart.js:444 > + this._overviewTimelineGrid.showCurtains(this._overviewCalculator._gapOffset, this._overviewCalculator._gapWidth); Curtains should be removed from that component. They are for a different thing. You should add draggable window here. > Source/WebCore/inspector/front-end/flameChart.css:30 > + left: 0px; timeline-cpu style is private to timeline. it should load lazily with timeline panel so it won't apply here.

Ilya Tikhonovsky

Comment 5 2013-03-20 08:22:35 PDT

Created attachment 194064 [details] Patch

Ilya Tikhonovsky

Comment 6 2013-03-20 08:24:31 PDT

Created attachment 194065 [details] new screenshot

Ilya Tikhonovsky

Comment 7 2013-03-20 08:53:13 PDT

Created attachment 194069 [details] Patch

Ilya Tikhonovsky

Comment 8 2013-03-20 08:54:37 PDT

it is the first patch from the set. See meta bug: https://bugs.webkit.org/show_bug.cgi?id=112814

Yury Semikhatsky

Comment 9 2013-03-20 09:08:11 PDT

Comment on attachment 194069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194069&action=review > Source/WebCore/ChangeLog:13 > + Drive by change: fix the drag window & drag resizer mechancs for the case when parent element has zero offsetLeft. mechancs ? > Source/WebCore/inspector/front-end/FlameChart.js:62 > + this._canvas.onmousemove = this._onMouseMove.bind(this); Why not addEventListener?

Ilya Tikhonovsky

Comment 10 2013-03-20 09:21:39 PDT

Committed r146354: <http://trac.webkit.org/changeset/146354>

Note You need to log in before you can comment on or make changes to this bug.