Bug 112489

Summary: [WebKit2][GTK] Initialize gettext also in the UIProcess side
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: NEW    
Severity: Normal CC: bugs-noreply, cgarcia, mrobinson, piotrdrag, svillar, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gustavo Noronha (kov)
Reported 2013-03-15 21:22:27 PDT
[WebKit2][GTK] Initialize gettext also in the UIProcess side
Attachments
Patch (1.70 KB, patch)
2013-03-15 21:24 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2013-03-15 21:24:22 PDT
Created attachment 193421 [details] Patch
WebKit Review Bot
Comment 2 2013-03-15 21:27:49 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2013-03-16 01:20:29 PDT
Comment on attachment 193421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193421&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.cpp:56 > +static __attribute__((constructor)) void wkInitialize() I guess we don't need to check whether constructor is supported by the compiler because we now require GCC >= 4.7 and Clang >= 3.0, right?
Gustavo Noronha (kov)
Comment 4 2013-03-17 07:21:20 PDT
Right! I checked clang supports this gcc extension, too.
Andreas Kling
Comment 5 2014-02-05 11:20:36 PST
Comment on attachment 193421 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Sergio Villar Senin
Comment 6 2014-02-06 00:12:47 PST
I think this is still valid
Note You need to log in before you can comment on or make changes to this bug.