| Summary: | [WebKit2][GTK] Initialize gettext also in the UIProcess side | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||
| Component: | New Bugs | Assignee: | Gustavo Noronha (kov) <gustavo> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mrobinson, piotrdrag, svillar, webkit.review.bot, xan.lopez | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gustavo Noronha (kov)
2013-03-15 21:22:27 PDT
Created attachment 193421 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 193421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193421&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.cpp:56 > +static __attribute__((constructor)) void wkInitialize() I guess we don't need to check whether constructor is supported by the compiler because we now require GCC >= 4.7 and Clang >= 3.0, right? Right! I checked clang supports this gcc extension, too. Comment on attachment 193421 [details]
Patch
Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
I think this is still valid |