Bug 112474

Summary:

REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Andy Estes 2013-03-15 15:57:43 PDT

REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()

Comment 1 Andy Estes 2013-03-15 16:00:39 PDT

Created attachment 193391 [details]
Patch

Comment 2 Simon Fraser (smfr) 2013-03-15 16:02:42 PDT

Comment on attachment 193391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193391&action=review

> Source/WebCore/platform/cf/SharedBufferCF.cpp:86
> +    RetainPtr<CFDataRef> cfData(AdoptCF, m_cfData.leakRef());

This should just assign.

Comment 3 Simon Fraser (smfr) 2013-03-15 16:08:21 PDT

Comment on attachment 193391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193391&action=review

>> Source/WebCore/platform/cf/SharedBufferCF.cpp:86
>> +    RetainPtr<CFDataRef> cfData(AdoptCF, m_cfData.leakRef());
> 
> This should just assign.

This is OK, after discussion.

Comment 4 Andy Estes 2013-03-15 16:13:44 PDT

Committed r145958: <http://trac.webkit.org/changeset/145958>