Bug 112469

Summary: Reduce amount of platform specific code in MessagePortChannel
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, esprehn+autocc, ojan.autocc, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
webkit.review.bot: commit-queue-
proposed patch sam: review+

Alexey Proskuryakov
Reported 2013-03-15 14:58:40 PDT
MessagePortChannel and PlatformMessagePortChannel classes are both implemented in forked files. MessagePortChannel doesn't have any logic of its own, so there is no reason to complicate the code by having these separate. This patch reduces the amount of calling through layers, making PlatformMessagePortChannel more of a data object, akin to ResourceHandleData.
Attachments
proposed patch (14.47 KB, patch)
2013-03-15 15:02 PDT, Alexey Proskuryakov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
proposed patch (14.62 KB, patch)
2013-03-15 15:50 PDT, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-03-15 15:02:07 PDT
Created attachment 193377 [details] proposed patch
WebKit Review Bot
Comment 2 2013-03-15 15:17:19 PDT
Comment on attachment 193377 [details] proposed patch Attachment 193377 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17118287
WebKit Review Bot
Comment 3 2013-03-15 15:24:26 PDT
Comment on attachment 193377 [details] proposed patch Attachment 193377 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17145314
Peter Beverloo (cr-android ews)
Comment 4 2013-03-15 15:42:59 PDT
Comment on attachment 193377 [details] proposed patch Attachment 193377 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17222123
Alexey Proskuryakov
Comment 5 2013-03-15 15:50:02 PDT
Created attachment 193387 [details] proposed patch Ok, ok.
Alexey Proskuryakov
Comment 6 2013-03-15 16:42:57 PDT
Committed <http://trac.webkit.org/changeset/145965>.
Note You need to log in before you can comment on or make changes to this bug.