Bug 112456

Summary:

Style Checker false pass

Product:

WebKit

Reporter:

Konrad Piascik <kpiascik>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn, kpiascik, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	ossy: review-, ossy: commit-queue-
patch fix	ossy: review+, commit-queue: commit-queue-
patch fix	none

Konrad Piascik

Reported 2013-03-15 11:28:33 PDT

When the style checker ran on this patch https://bugs.webkit.org/attachment.cgi?id=193319&action=review it passed both locally with webkit-patch and remotely on EWS's style checker.

Attachments
patch (1.36 KB, patch) 2013-11-29 01:58 PST, Gergő Balogh	ossy: review- ossy: commit-queue-	Details Formatted Diff Diff
patch fix (2.57 KB, patch) 2013-11-29 05:25 PST, Gergő Balogh	ossy: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
patch fix (2.57 KB, patch) 2013-11-29 06:15 PST, Gergő Balogh	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Konrad Piascik

Comment 1 2013-03-15 11:29:44 PDT

(In reply to comment #0) > When the style checker ran on this patch https://bugs.webkit.org/attachment.cgi?id=193319&action=review it passed both locally with webkit-patch and remotely on EWS's style checker. This patch has "No new tests (OOPS!)." so I would expect it to fail style.

Gergő Balogh

Comment 2 2013-11-29 01:58:24 PST

Created attachment 218043 [details] patch I just correct the regular expression for "No new tests (OOPS!)."

Csaba Osztrogonác

Comment 3 2013-11-29 02:12:18 PST

Comment on attachment 218043 [details] patch Please update its unittest and the comment above too.

Gergő Balogh

Comment 4 2013-11-29 05:25:59 PST

Created attachment 218054 [details] patch fix

WebKit Commit Bot

Comment 5 2013-11-29 05:38:08 PST

Comment on attachment 218054 [details] patch fix Rejecting attachment 218054 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 218054, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/39318135

Csaba Osztrogonác

Comment 6 2013-11-29 05:42:49 PST

Comment on attachment 218054 [details] patch fix View in context: https://bugs.webkit.org/attachment.cgi?id=218054&action=review > Tools/ChangeLog:10 > + simple regex fix to check "No new tests (OOPS!)." Hehe, this comment killed the CQ. :)

Gergő Balogh

Comment 7 2013-11-29 06:15:27 PST

Created attachment 218056 [details] patch fix HOPPA! == OOPS!

Csaba Osztrogonác

Comment 8 2013-12-03 04:27:20 PST

Comment on attachment 218056 [details] patch fix View in context: https://bugs.webkit.org/attachment.cgi?id=218056&action=review > Tools/ChangeLog:10 > + simple regex fix to check "No new tests (HOPPA!)." We shouldn't write "hoppá", otherwise LGTM.

Csaba Osztrogonác

Comment 9 2013-12-03 04:28:38 PST

Landed in http://trac.webkit.org/changeset/159997

Note You need to log in before you can comment on or make changes to this bug.