Bug 112448

Summary: [BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
none
Patch none

Alberto Garcia
Reported 2013-03-15 08:16:44 PDT
This changed in r121381 (see bug 89123).
Attachments
Patch (1.26 KB, patch)
2013-03-15 08:18 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch (1.25 KB, patch)
2013-03-21 12:31 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-15 08:18:03 PDT
Created attachment 193313 [details] Patch
Xan Lopez
Comment 2 2013-03-21 11:54:13 PDT
Comment on attachment 193313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193313&action=review > Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:35 > + JSC::JSLockHolder lock(m_globalData); Seems weird that JSLock didn't need the explicit namespace but JSLockHolder does. Other than that seems sensible given the patch in the other bug.
Alberto Garcia
Comment 3 2013-03-21 12:31:23 PDT
Created attachment 194316 [details] Patch Right, here's the updated patch.
Xan Lopez
Comment 4 2013-03-21 12:53:00 PDT
Comment on attachment 194316 [details] Patch Bam.
WebKit Review Bot
Comment 5 2013-03-21 12:57:50 PDT
Comment on attachment 194316 [details] Patch Clearing flags on attachment: 194316 Committed r146502: <http://trac.webkit.org/changeset/146502>
WebKit Review Bot
Comment 6 2013-03-21 12:57:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.