Summary: | Support connecting the Web Inspector without showing it | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||||||
Component: | WebKit2 | Assignee: | Timothy Hatcher <timothy> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abecsi, andersca, cmarcelo, graouts, gyuyoung.kim, joepeck, menard, rakuco, rniwa, sam, timothy, webkit-bug-importer, webkit-ews, webkit.review.bot | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Timothy Hatcher
2013-03-15 07:30:23 PDT
Created attachment 193307 [details]
Proposed Change
Created attachment 193314 [details]
Proposed Change (Take 2)
Comment on attachment 193314 [details]
Proposed Change (Take 2)
Looks good to me.
Anders, Sam, want to do a quick review of this? Created attachment 193437 [details]
Proposed Change (Take 3)
I've simplified some things since the last patch.
Comment on attachment 193437 [details] Proposed Change (Take 3) Attachment 193437 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17188423 Comment on attachment 193437 [details] Proposed Change (Take 3) Attachment 193437 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17222202 Comment on attachment 193437 [details] Proposed Change (Take 3) View in context: https://bugs.webkit.org/attachment.cgi?id=193437&action=review > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:413 > + WKView *inspectedView = m_page->wkView(); Please don't access the WKView directly here (that function should be removed). Instead, this should go through the PageClient. Comment on attachment 193437 [details] Proposed Change (Take 3) View in context: https://bugs.webkit.org/attachment.cgi?id=193437&action=review >> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:413 >> + WKView *inspectedView = m_page->wkView(); > > Please don't access the WKView directly here (that function should be removed). Instead, this should go through the PageClient. This isn't new to this patch, we use wkView in a couple other places in this file. PageClient isn't exposed on WebPageProxy right now. I'd like to keep this patch as-is. I filed bug 112829 to track that. Created attachment 194102 [details]
Proposed Change (Take 4)
Comment on attachment 194102 [details] Proposed Change (Take 4) Attachment 194102 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17258038 Created attachment 194108 [details]
Proposed Change (Take 5)
Comment on attachment 194108 [details] Proposed Change (Take 5) Attachment 194108 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17253236 Created attachment 194122 [details]
Proposed Change (Take 6)
Sam or Anders, mind taking a look at take 6? Comment on attachment 194122 [details] Proposed Change (Take 6) Clearing flags on attachment: 194122 Committed r146518: <http://trac.webkit.org/changeset/146518> All reviewed patches have been landed. Closing bug. This patch appears to have broken two tests on ML Debug testers: e.g. http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r146520%20(8040)/results.html This patch may have caused inspector/profiler/cpu-profiler-profile-removal.html to intermittently crash. See: https://bugs.webkit.org/show_bug.cgi?id=113020 These are ASSERTs. I am looking into it. |