Bug 112438

Summary: [BlackBerry] Remove PlatformSupport
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch none

Alberto Garcia
Reported 2013-03-15 05:58:03 PDT
That class only contains getFontFamilyForCharacters(), which was moved from PlatformSupport to FontCache in r129257 (see bug 96282).
Attachments
Patch (14.30 KB, patch)
2013-03-15 06:03 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-15 06:03:37 PDT
Created attachment 193291 [details] Patch Here's the patch. The problem is that we change the API, so if we cannot revert it we need an #ifdef in FontCache.h
Rob Buis
Comment 2 2013-03-15 06:24:31 PDT
Comment on attachment 193291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193291&action=review > Source/WebCore/platform/graphics/FontCache.h:132 > +#endif Do we really need a different signature?
Rob Buis
Comment 3 2013-03-15 06:35:24 PDT
Comment on attachment 193291 [details] Patch Good idea!
WebKit Review Bot
Comment 4 2013-03-15 06:54:32 PDT
Comment on attachment 193291 [details] Patch Clearing flags on attachment: 193291 Committed r145903: <http://trac.webkit.org/changeset/145903>
WebKit Review Bot
Comment 5 2013-03-15 06:54:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.