Bug 112438 - [BlackBerry] Remove PlatformSupport
Summary: [BlackBerry] Remove PlatformSupport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-03-15 05:58 PDT by Alberto Garcia
Modified: 2013-03-15 06:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (14.30 KB, patch)
2013-03-15 06:03 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-15 05:58:03 PDT 
That class only contains getFontFamilyForCharacters(), which was moved
from PlatformSupport to FontCache in r129257 (see bug 96282).
Comment 1 Alberto Garcia 2013-03-15 06:03:37 PDT 
Created attachment 193291 [details]
Patch

Here's the patch.

The problem is that we change the API, so if we cannot revert it we need an #ifdef in FontCache.h
Comment 2 Rob Buis 2013-03-15 06:24:31 PDT 
Comment on attachment 193291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193291&action=review

> Source/WebCore/platform/graphics/FontCache.h:132
> +#endif

Do we really need a different signature?
Comment 3 Rob Buis 2013-03-15 06:35:24 PDT 
Comment on attachment 193291 [details]
Patch

Good idea!
Comment 4 WebKit Review Bot 2013-03-15 06:54:32 PDT 
Comment on attachment 193291 [details]
Patch

Clearing flags on attachment: 193291

Committed r145903: <http://trac.webkit.org/changeset/145903>
Comment 5 WebKit Review Bot 2013-03-15 06:54:36 PDT 
All reviewed patches have been landed.  Closing bug.