Bug 112424

Summary: [BlackBerry] Detach overlays from page when compositor is detached
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Arvid Nilsson <anilsson>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, jpetsovits, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Arvid Nilsson
Reported 2013-03-15 03:08:57 PDT
Otherwise the overlays will have a dangling pointer to the WebPage. We don't bother with webkit-thread overlays, since they are obsolete (and only used internally in WebKit, so they go down together with the WebPage anyway). PR 309160
Attachments
Patch (10.51 KB, patch)
2013-03-18 05:27 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2013-03-18 05:27:07 PDT
Created attachment 193542 [details] Patch
Rob Buis
Comment 2 2013-03-18 05:32:26 PDT
Comment on attachment 193542 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2013-03-18 06:07:38 PDT
Comment on attachment 193542 [details] Patch Clearing flags on attachment: 193542 Committed r146058: <http://trac.webkit.org/changeset/146058>
WebKit Review Bot
Comment 4 2013-03-18 06:07:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.