Bug 112402

Summary: Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Eugene Klyuchnikov
Reported 2013-03-14 21:58:56 PDT
Original issue: https://code.google.com/p/chromium/issues/detail?id=195100 Dev Tools -- Resources -- Unable to delete newly added keys under Local Storage. Recent changes removed forced "refresh" on editing. So duplicate keys do not combine with existing ones in UI.
Attachments
Patch (4.74 KB, patch)
2013-03-15 02:49 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2013-03-18 03:52 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (3.35 KB, patch)
2013-03-18 05:21 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-15 01:55:30 PDT
Qualification: in case value is changed - all goes well. But in case value is not changed (it was already empty) - we receive no notification -> dupe is not removed.
Eugene Klyuchnikov
Comment 2 2013-03-15 02:49:44 PDT
Created attachment 193265 [details] Patch
Eugene Klyuchnikov
Comment 3 2013-03-18 03:52:39 PDT
Created attachment 193521 [details] Patch less-invasive-patch
Alexander Pavlov (apavlov)
Comment 4 2013-03-18 04:23:00 PDT
Comment on attachment 193521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193521&action=review > Source/WebCore/ChangeLog:8 > + Avoid duplicates in case value is not updated (consequently, Please give a more detailed description of what's wrong and how this patch fixes the bug (the issue summary is not helpful either.) > Source/WebCore/inspector/front-end/DOMStorageItemsView.js:250 > + masterNode.select(); Either this line should follow the method call or the method should be named, _removeDupesAndSelect.
Eugene Klyuchnikov
Comment 5 2013-03-18 05:15:42 PDT
Comment on attachment 193521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193521&action=review >> Source/WebCore/ChangeLog:8 >> + Avoid duplicates in case value is not updated (consequently, > > Please give a more detailed description of what's wrong and how this patch fixes the bug (the issue summary is not helpful either.) Done. >> Source/WebCore/inspector/front-end/DOMStorageItemsView.js:250 >> + masterNode.select(); > > Either this line should follow the method call or the method should be named, _removeDupesAndSelect. Addressed.
Eugene Klyuchnikov
Comment 6 2013-03-18 05:21:05 PDT
Created attachment 193539 [details] Patch
WebKit Review Bot
Comment 7 2013-03-18 05:55:07 PDT
Comment on attachment 193539 [details] Patch Clearing flags on attachment: 193539 Committed r146057: <http://trac.webkit.org/changeset/146057>
WebKit Review Bot
Comment 8 2013-03-18 05:55:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.