Bug 112385

Summary: [Chromium] Focus Plugin on TouchStart
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, sadrul, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Fady Samuel
Reported 2013-03-14 15:01:22 PDT
[Chromium] Focus Plugin on TouchStart
Attachments
Patch (1.75 KB, patch)
2013-03-14 15:01 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (3.55 KB, patch)
2013-03-15 13:25 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2013-03-14 15:01:36 PDT
Created attachment 193193 [details] Patch
Sadrul Habib Chowdhury
Comment 2 2013-03-14 15:18:50 PDT
Since we do this for mouse-down events, I think it makes sense to do this on touch-press events too. LGTM
Adam Barth
Comment 3 2013-03-15 11:03:56 PDT
Comment on attachment 193193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193193&action=review > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:779 > + Frame* containingFrame = static_cast<FrameView*>(parent())->frame(); > + if (Page* currentPage = containingFrame->page()) > + currentPage->focusController()->setFocusedNode(m_element, containingFrame); > + else > + containingFrame->document()->setFocusedNode(m_element); This seems copy/pasted from WebPluginContainerImpl::handleMouseEvent. Can we create a small helper function rather than copy/pasting code?
Fady Samuel
Comment 4 2013-03-15 13:25:12 PDT
Created attachment 193366 [details] Patch
WebKit Review Bot
Comment 5 2013-03-15 16:03:38 PDT
Comment on attachment 193366 [details] Patch Clearing flags on attachment: 193366 Committed r145957: <http://trac.webkit.org/changeset/145957>
WebKit Review Bot
Comment 6 2013-03-15 16:03:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.