Bug 112384

Summary:

[chromium] Small pixel differences in scroll bars after r145844

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

Tools / Tests

Assignee:

Robert Flack <flackr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

102580

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Kenneth Russell

Reported 2013-03-14 14:58:11 PDT

The following layout tests have small pixel differences in their rendering on Win7, apparently after http://trac.webkit.org/changeset/145844 : fast/forms/basic-textareas-quirks.html fast/forms/basic-textareas.html fast/overflow/overflow-x-y.html fast/parser/open-comment-in-textarea.html fast/replaced/width100percent-textarea.html Looking at the differences it isn't 100% clear to me that the new behavior is desired; the scroll bar and top arrow look slightly worse to me. Assigning this bug to flackr to take a look. To see the differences, run webkit-patch garden-o-matic and look for these tests. I may try to suppress these failures in the meantime, so you may need to look under the "expected failures" tab for them.

Attachments
Patch (313.77 KB, patch) 2013-03-18 08:50 PDT, Robert Flack	no flags	Details Formatted Diff Diff
Patch (314.87 KB, patch) 2013-03-18 08:54 PDT, Robert Flack	no flags	Details Formatted Diff Diff
Patch (321.38 KB, patch) 2013-03-18 17:33 PDT, Robert Flack	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Robert Flack

Comment 1 2013-03-15 11:07:44 PDT

The difference in the arrow is very strange. As for the track I did expect the difference but I can see that not drawing a 1px track between scroll bar buttons may be preferred. Looking into this.

Robert Flack

Comment 2 2013-03-18 08:50:27 PDT

Created attachment 193573 [details] Patch

Robert Flack

Comment 3 2013-03-18 08:54:51 PDT

Created attachment 193574 [details] Patch

Kenneth Russell

Comment 4 2013-03-18 11:42:47 PDT

Comment on attachment 193574 [details] Patch Thanks for the update. Seems fine. r=me

Robert Flack

Comment 5 2013-03-18 17:33:09 PDT

Created attachment 193703 [details] Patch