Bug 112358

Summary: [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: philn, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Xabier Rodríguez Calvar
Reported 2013-03-14 10:11:04 PDT
[GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
Attachments
Patch (2.60 KB, patch)
2013-03-14 10:12 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2013-03-14 10:23 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2013-03-14 10:12:00 PDT
Created attachment 193144 [details] Patch Guarding with #if ENABLE(VIDEO).
Philippe Normand
Comment 2 2013-03-14 10:17:22 PDT
Comment on attachment 193144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193144&action=review Looks good! But please provide a changelog > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Missing change explanation...
Xabier Rodríguez Calvar
Comment 3 2013-03-14 10:23:31 PDT
Created attachment 193145 [details] Patch Clarified changelog.
Philippe Normand
Comment 4 2013-03-14 10:26:57 PDT
Comment on attachment 193145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193145&action=review > Source/WebCore/ChangeLog:9 > + Guarded with ENABLE(VIDEO) to prevent problems when it is not > + enabled. > + > + Reviewed by NOBODY (OOPS!). Reviewed by usually goes before the explanation.
WebKit Review Bot
Comment 5 2013-03-14 11:39:40 PDT
Comment on attachment 193145 [details] Patch Clearing flags on attachment: 193145 Committed r145831: <http://trac.webkit.org/changeset/145831>
WebKit Review Bot
Comment 6 2013-03-14 11:39:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.