Bug 112358

Summary: [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: philn, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Xabier Rodríguez Calvar 2013-03-14 10:11:04 PDT 
[GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
Comment 1 Xabier Rodríguez Calvar 2013-03-14 10:12:00 PDT 
Created attachment 193144 [details]
Patch

Guarding with #if ENABLE(VIDEO).
Comment 2 Philippe Normand 2013-03-14 10:17:22 PDT 
Comment on attachment 193144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193144&action=review

Looks good! But please provide a changelog

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Missing change explanation...
Comment 3 Xabier Rodríguez Calvar 2013-03-14 10:23:31 PDT 
Created attachment 193145 [details]
Patch

Clarified changelog.
Comment 4 Philippe Normand 2013-03-14 10:26:57 PDT 
Comment on attachment 193145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193145&action=review

> Source/WebCore/ChangeLog:9
> +        Guarded with ENABLE(VIDEO) to prevent problems when it is not
> +        enabled.
> +
> +        Reviewed by NOBODY (OOPS!).

Reviewed by usually goes before the explanation.
Comment 5 WebKit Review Bot 2013-03-14 11:39:40 PDT 
Comment on attachment 193145 [details]
Patch

Clearing flags on attachment: 193145

Committed r145831: <http://trac.webkit.org/changeset/145831>
Comment 6 WebKit Review Bot 2013-03-14 11:39:43 PDT 
All reviewed patches have been landed.  Closing bug.