Bug 112357 – Roll Chromium DEPS to r188004

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

A DEPS roll a day keeps the build break away.

[WebKit Review Bot]

Created attachment 193138 [details]
Patch

[WebKit Review Bot]

Comment on attachment 193138 [details]
Patch

Rejecting attachment 193138 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
 in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Source/WebKit/chromium/depot_tools/ninja -C out/Release all 
ninja: Entering directory `out/Release'
ninja: error: '../../Source/WebKit/chromium/tools/protoc_wrapper/protoc_wrapper.py', needed by 'pyproto/gpu/command_buffer/service/disk_cache_proto_pb2.py', missing and no known rule to make it

Full output: http://webkit-commit-queue.appspot.com/results/17210180

[Dana Jansens]

Is something broken in webkit or in chromium here? I couldn't roll all day yesterday either.

[James Robinson]

dsinclair's GPU shader caching logic added a dependency from gpu/ on the protocol buffer compiler, which we don't pull in the chromium-inside-WebKit configuration.  This breaks the roll.  I'll see what would be necessary to pull to get this working again, hopefully it's not much.

[Dana Jansens]

thanks james.

[WebKit Review Bot]

Comment on attachment 193138 [details]
Patch

Clearing flags on attachment: 193138

Committed r145835: <http://trac.webkit.org/changeset/145835>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.