Summary: | Web Inspector: Make Source Frame & status bar a layout boundary | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Lushnikov <lushnikov> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Lushnikov <lushnikov> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Andrey Lushnikov
2013-03-14 08:30:34 PDT
Created attachment 193129 [details]
Patch
Comment on attachment 193129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193129&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:697 > + this.element.style.height = this.element.parentElement.offsetHeight + "px"; We could do this for all views that use "fill" style. I.e. we make all views have a "view" classname and for ".view .fill" we make it a boundary. "fill" guarantees absolute positioning, so .view .fill would need to add width: 100%, overflow and you take care of the height here. So you magically fix everything at once. > Source/WebCore/inspector/front-end/inspector.css:53 > + /* position must be relative or absolute */ You could set position: relative here since it is not affecting the layout by default. And you could specify the height of 300px so that clients were forced to override it. Created attachment 193512 [details]
Patch
Comment on attachment 193512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193512&action=review > Source/WebCore/inspector/front-end/CSSNamedFlowCollectionsView.js:44 > + this.fillElement(); fillParent > Source/WebCore/inspector/front-end/View.js:153 > + this.element.style.height = ""; style.removeProperty("height") > Source/WebCore/inspector/front-end/inspector.css:36 > + overflow: hidden; What about views that contain large elements (and hence have overflows?) Created attachment 196170 [details]
Patch
Comment on attachment 196170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196170&action=review > Source/WebCore/inspector/front-end/View.js:157 > + this.element.style.height = ""; removeProperty Created attachment 196185 [details]
Patch
Comment on attachment 196185 [details] Patch Clearing flags on attachment: 196185 Committed r147478: <http://trac.webkit.org/changeset/147478> All reviewed patches have been landed. Closing bug. |