Bug 112353 – Web Inspector: Make Source Frame & status bar a layout boundary

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Andrey Lushnikov]

Make source frame & status bar a layout boundary. This will improve text editing performance, because edits make editor to invalidate its dom and update source position element, which is located in status bar.

[Andrey Lushnikov]

Created attachment 193129 [details]
Patch

[Pavel Feldman]

Comment on attachment 193129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193129&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:697
> +        this.element.style.height = this.element.parentElement.offsetHeight + "px";

We could do this for all views that use "fill" style. I.e. we make all views have a "view" classname and for  ".view .fill" we make it a boundary. "fill" guarantees absolute positioning, so .view .fill would need to add width: 100%, overflow and you take care of the height here. So you magically fix everything at once.

> Source/WebCore/inspector/front-end/inspector.css:53
> +    /* position must be relative or absolute */

You could set position: relative here since it is not affecting the layout by default. And you could specify the height of 300px so that clients were forced to override it.

[Andrey Lushnikov]

Created attachment 193512 [details]
Patch

[Pavel Feldman]

Comment on attachment 193512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193512&action=review

> Source/WebCore/inspector/front-end/CSSNamedFlowCollectionsView.js:44
> +    this.fillElement();

fillParent

> Source/WebCore/inspector/front-end/View.js:153
> +            this.element.style.height = "";

style.removeProperty("height")

> Source/WebCore/inspector/front-end/inspector.css:36
> +    overflow: hidden;

What about views that contain large elements (and hence have overflows?)

[Andrey Lushnikov]

Created attachment 196170 [details]
Patch

[Pavel Feldman]

Comment on attachment 196170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196170&action=review

> Source/WebCore/inspector/front-end/View.js:157
> +            this.element.style.height = "";

removeProperty

[Andrey Lushnikov]

Created attachment 196185 [details]
Patch

[WebKit Review Bot]

Comment on attachment 196185 [details]
Patch

Clearing flags on attachment: 196185

Committed r147478: <http://trac.webkit.org/changeset/147478>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.