Bug 112342 – Expose whether a UserGestureToken still has gestures via WebKit API

• Component: New Bugs
• Status: RESOLVED FIXED

Expose whether a UserGestureToken still has gestures via WebKit API

Created attachment 193109 [details]
Patch

The PPAPI uses WebScopedUserGestures and WebUserGestureTokens to indicate user gestures up to 10s after the gesture happened.

When no gesture is active, a corresponding error is reported back to the plugin.

With this change, the PPAPI can check whether a token was consumed and cancel the 10s period.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 193109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193109&action=review

> Source/WebCore/dom/UserGestureIndicator.h:45
> +    virtual bool hasGestures() const = 0;

Why do we have this virtual interface.  Are there other implementations of UserGestureToken?

Comment on attachment 193109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193109&action=review

>> Source/WebCore/dom/UserGestureIndicator.h:45
>> +    virtual bool hasGestures() const = 0;
> 
> Why do we have this virtual interface.  Are there other implementations of UserGestureToken?

no, I just want to hide the addGesture() call, so nobody comes up with the idea of adding gestures to a token

[WebKit Review Bot]

Comment on attachment 193109 [details]
Patch

Clearing flags on attachment: 193109

Committed r145944: <http://trac.webkit.org/changeset/145944>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.