RESOLVED FIXED 112342
Expose whether a UserGestureToken still has gestures via WebKit API 
https://bugs.webkit.org/show_bug.cgi?id=112342
Summary Expose whether a UserGestureToken still has gestures via WebKit API
jochen
Reported 2013-03-14 05:43:36 PDT
Expose whether a UserGestureToken still has gestures via WebKit API
Attachments
Patch (5.07 KB, patch)
2013-03-14 05:43 PDT, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-03-14 05:43:56 PDT
Created attachment 193109 [details] Patch
jochen
Comment 2 2013-03-14 05:45:37 PDT
The PPAPI uses WebScopedUserGestures and WebUserGestureTokens to indicate user gestures up to 10s after the gesture happened. When no gesture is active, a corresponding error is reported back to the plugin. With this change, the PPAPI can check whether a token was consumed and cancel the 10s period.
WebKit Review Bot
Comment 3 2013-03-14 05:46:43 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2013-03-15 12:28:24 PDT
Comment on attachment 193109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193109&action=review > Source/WebCore/dom/UserGestureIndicator.h:45 > + virtual bool hasGestures() const = 0; Why do we have this virtual interface. Are there other implementations of UserGestureToken?
jochen
Comment 5 2013-03-15 12:52:14 PDT
Comment on attachment 193109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193109&action=review >> Source/WebCore/dom/UserGestureIndicator.h:45 >> + virtual bool hasGestures() const = 0; > > Why do we have this virtual interface. Are there other implementations of UserGestureToken? no, I just want to hide the addGesture() call, so nobody comes up with the idea of adding gestures to a token
WebKit Review Bot
Comment 6 2013-03-15 14:54:38 PDT
Comment on attachment 193109 [details] Patch Clearing flags on attachment: 193109 Committed r145944: <http://trac.webkit.org/changeset/145944>
WebKit Review Bot
Comment 7 2013-03-15 14:54:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.