Bug 112337

Summary: Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2013-03-14 03:10:54 PDT
EOM
Attachments
Patch (5.77 KB, patch)
2013-03-14 03:21 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-03-14 03:21:06 PDT
Created attachment 193099 [details] Patch
Yury Semikhatsky
Comment 2 2013-03-14 05:33:07 PDT
Comment on attachment 193099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193099&action=review > Source/WebCore/inspector/front-end/FlameChart.js:224 > + this._xScaleFactor = --this._xScaleFactor > minXScaleFactor ? this._xScaleFactor : minXScaleFactor; if (--this._xScaleFactor < minScaleFactor) this._xScaleFactor = minScaleFactor; Also this._xScaleFactor is a floating point number, should it be int?
Ilya Tikhonovsky
Comment 3 2013-03-14 06:35:27 PDT
(In reply to comment #2) > (From update of attachment 193099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=193099&action=review > > > Source/WebCore/inspector/front-end/FlameChart.js:224 > > + this._xScaleFactor = --this._xScaleFactor > minXScaleFactor ? this._xScaleFactor : minXScaleFactor; > > if (--this._xScaleFactor < minScaleFactor) > this._xScaleFactor = minScaleFactor; > > Also this._xScaleFactor is a floating point number, should it be int? Actually it has to be 2^n where n could be negative.
Ilya Tikhonovsky
Comment 4 2013-03-14 06:38:22 PDT
Committed r145807: <http://trac.webkit.org/changeset/145807>
Note You need to log in before you can comment on or make changes to this bug.