Bug 112321

Summary: Web Inspector: [Network] Sort columns context menu items alphabetically.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Eugene Klyuchnikov
Reported 2013-03-13 23:02:39 PDT
Columns are presented in "natural" order -> it is hard to find specific item.
Attachments
Patch (2.89 KB, patch)
2013-03-13 23:12 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (5.18 KB, patch)
2013-03-14 06:23 PDT, Eugene Klyuchnikov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-13 23:12:09 PDT
Created attachment 193068 [details] Patch
Pavel Feldman
Comment 2 2013-03-13 23:36:51 PDT
Comment on attachment 193068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193068&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:996 > + var title1 = columns[id1].name || columns[id1].title || ""; You should sort by title, not name.
Eugene Klyuchnikov
Comment 3 2013-03-14 02:53:03 PDT
Comment on attachment 193068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193068&action=review >> Source/WebCore/inspector/front-end/NetworkPanel.js:996 >> + var title1 = columns[id1].name || columns[id1].title || ""; > > You should sort by title, not name. Objection. We should sort by item title user see in menu. Menu item title is "column.name || column.title". This is because title could be presented with titleDOMFragment.
Eugene Klyuchnikov
Comment 4 2013-03-14 06:23:47 PDT
Created attachment 193114 [details] Patch
Eugene Klyuchnikov
Comment 5 2013-03-15 01:31:15 PDT
Committed r145886: <http://trac.webkit.org/changeset/145886>
Note You need to log in before you can comment on or make changes to this bug.