Bug 112317

Summary: Need to use const String in HTMLVideoElement::posterImageURL
Product: WebKit Reporter: michaelbai
Component: DOMAssignee: michaelbai
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, esprehn+autocc, feature-media-reviews, jer.noble, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

michaelbai
Reported 2013-03-13 20:16:34 PDT
Need to use const String instead of "const AtomicString&" which means we’ll do an extra hash lookup
Attachments
Patch (1.63 KB, patch)
2013-03-13 20:23 PDT, michaelbai 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2013-03-13 20:29 PDT, michaelbai 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2013-03-14 10:04 PDT, michaelbai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
michaelbai
Comment 1 2013-03-13 20:23:36 PDT
Created attachment 193054 [details] Patch
michaelbai
Comment 2 2013-03-13 20:29:45 PDT
Created attachment 193055 [details] Patch
Alexey Proskuryakov
Comment 3 2013-03-14 09:54:34 PDT
Comment on attachment 193055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193055&action=review r=me with correction below. > Source/WebCore/ChangeLog:11 > + Need to use const String instead of const AtomicString& which means we will do an extra hash lookup We don't normally use const with local variables, so not "const String". > Source/WebCore/html/HTMLVideoElement.cpp:320 > + const String url = stripLeadingAndTrailingHTMLSpaces(imageSourceURL()); Should be "String", not "const String"
michaelbai
Comment 4 2013-03-14 10:04:03 PDT
Created attachment 193143 [details] Patch
michaelbai
Comment 5 2013-03-14 10:04:47 PDT
Comment on attachment 193055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193055&action=review >> Source/WebCore/ChangeLog:11 >> + Need to use const String instead of const AtomicString& which means we will do an extra hash lookup > > We don't normally use const with local variables, so not "const String". Change to use string. thanks
WebKit Review Bot
Comment 6 2013-03-18 09:14:22 PDT
Comment on attachment 193143 [details] Patch Clearing flags on attachment: 193143 Committed r146069: <http://trac.webkit.org/changeset/146069>
WebKit Review Bot
Comment 7 2013-03-18 09:14:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.