Bug 112291

Summary: run-perf-tests should support content_shell
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, jochen, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
work in progress
none
Patch
none
Patch for landing none

Description Adam Barth 2013-03-13 14:30:22 PDT 
run-perf-tests should support content_shell
Comment 1 Adam Barth 2013-03-13 14:30:34 PDT 
Created attachment 192992 [details]
work in progress
Comment 2 Adam Barth 2013-03-13 14:37:04 PDT 
Created attachment 192997 [details]
Patch
Comment 3 Eric Seidel (no email) 2013-03-13 14:39:21 PDT 
Comment on attachment 192997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192997&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:238
> +        re.compile(r'INFO:SkFontHost_fontconfig.cpp'),
> +        re.compile(r'Running without the SUID sandbox'),

You might want to mark that these are from content_shell in a comment.
Comment 4 jochen 2013-03-13 14:40:54 PDT 
Comment on attachment 192997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192997&action=review

>> Tools/Scripts/webkitpy/performance_tests/perftest.py:238
>> +        re.compile(r'Running without the SUID sandbox'),
> 
> You might want to mark that these are from content_shell in a comment.

Or just install the SUID sandbox... https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment
Comment 5 Adam Barth 2013-03-13 14:45:54 PDT 
> Or just install the SUID sandbox... https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment

That would solve the problem for me, but other folks would run into the error.
Comment 6 Adam Barth 2013-03-13 14:46:47 PDT 
Created attachment 192998 [details]
Patch for landing
Comment 7 jochen 2013-03-13 14:47:51 PDT 
Doesn't the error include the link how to fix it?

I think the idea is that running any browser without a sandbox is bad.

However, since content_shell in DRT mode doesn't allow outgoing connections anyway, I guess it doesn't really matter.
Comment 8 Adam Barth 2013-03-13 15:02:41 PDT 
> Doesn't the error include the link how to fix it?

Yes, but I want to run performance tests, not fix configurations problems.  :)

> However, since content_shell in DRT mode doesn't allow outgoing connections anyway, I guess it doesn't really matter.

Maybe I should fix it, but it should block me from profiling "<html>".
Comment 9 WebKit Review Bot 2013-03-13 15:36:24 PDT 
Comment on attachment 192998 [details]
Patch for landing

Clearing flags on attachment: 192998

Committed r145764: <http://trac.webkit.org/changeset/145764>
Comment 10 WebKit Review Bot 2013-03-13 15:36:28 PDT 
All reviewed patches have been landed.  Closing bug.