Bug 112289

Summary: [WK2][EFL] Get rid of WebPageProxy::viewWidget() method
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
eflews.bot: commit-queue-
run EWS
none
patch v2 none

Mikhail Pozdnyakov
Reported 2013-03-13 13:54:58 PDT
SSIA. Heaving this method inside web page is broken design: web page should not be aware of platform-specific view.
Attachments
patch (5.85 KB, patch)
2013-03-13 14:05 PDT, Mikhail Pozdnyakov 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
run EWS (6.73 KB, patch)
2013-03-14 11:49 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v2 (6.63 KB, patch)
2013-03-14 13:18 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2013-03-13 14:05:15 PDT
Created attachment 192990 [details] patch
Kenneth Rohde Christiansen
Comment 2 2013-03-13 14:31:47 PDT
Comment on attachment 192990 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=192990&action=review nice > Source/WebKit2/ChangeLog:9 > + Having viewWidget() method inside web page is broken design: web > + page should not be aware of platform-specific view. I would refrase that.
EFL EWS Bot
Comment 3 2013-03-13 16:29:14 PDT
Comment on attachment 192990 [details] patch Attachment 192990 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17199068
Mikhail Pozdnyakov
Comment 4 2013-03-14 08:31:50 PDT
(In reply to comment #3) > (From update of attachment 192990 [details]) > Attachment 192990 [details] did not pass efl-ews (efl): > Output: http://webkit-commit-queue.appspot.com/results/17199068 Weird.. I cannot reproduce it locally.
Gyuyoung Kim
Comment 5 2013-03-14 09:34:43 PDT
Comment on attachment 192990 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=192990&action=review > Source/WebKit2/PlatformEfl.cmake:-85 > - UIProcess/cairo/BackingStoreCairo.cpp To help you, I can reproduce build error when I build WebKit EFL with this patch locally. It looks these build error comes from removing this file. ../../lib/libewebkit2.so.0.1.0: undefined reference to `WebKit::BackingStore::paint(_cairo*, WebCore::IntRect const&)' ../../lib/libewebkit2.so.0.1.0: undefined reference to `WebKit::BackingStore::incorporateUpdate(WebKit::ShareableBitmap*, WebKit::UpdateInfo const&)'
Mikhail Pozdnyakov
Comment 6 2013-03-14 11:49:06 PDT
Created attachment 193165 [details] run EWS
Mikhail Pozdnyakov
Comment 7 2013-03-14 13:18:10 PDT
Created attachment 193176 [details] patch v2 fix build: do not exclude BackingStoreCairo.cpp from cmake.
Alexey Proskuryakov
Comment 8 2013-03-14 13:26:39 PDT
Comment on attachment 193176 [details] patch v2 r=me (largely taking in consideration Kenneth's approval).
Kenneth Rohde Christiansen
Comment 9 2013-03-14 15:47:47 PDT
Great!
WebKit Review Bot
Comment 10 2013-03-15 00:15:43 PDT
Comment on attachment 193176 [details] patch v2 Clearing flags on attachment: 193176 Committed r145880: <http://trac.webkit.org/changeset/145880>
WebKit Review Bot
Comment 11 2013-03-15 00:15:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.