Summary: | [WK2][EFL] Get rid of WebPageProxy::viewWidget() method | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2013-03-13 13:54:58 PDT
Created attachment 192990 [details]
patch
Comment on attachment 192990 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=192990&action=review nice > Source/WebKit2/ChangeLog:9 > + Having viewWidget() method inside web page is broken design: web > + page should not be aware of platform-specific view. I would refrase that. Comment on attachment 192990 [details] patch Attachment 192990 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17199068 (In reply to comment #3) > (From update of attachment 192990 [details]) > Attachment 192990 [details] did not pass efl-ews (efl): > Output: http://webkit-commit-queue.appspot.com/results/17199068 Weird.. I cannot reproduce it locally. Comment on attachment 192990 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=192990&action=review > Source/WebKit2/PlatformEfl.cmake:-85 > - UIProcess/cairo/BackingStoreCairo.cpp To help you, I can reproduce build error when I build WebKit EFL with this patch locally. It looks these build error comes from removing this file. ../../lib/libewebkit2.so.0.1.0: undefined reference to `WebKit::BackingStore::paint(_cairo*, WebCore::IntRect const&)' ../../lib/libewebkit2.so.0.1.0: undefined reference to `WebKit::BackingStore::incorporateUpdate(WebKit::ShareableBitmap*, WebKit::UpdateInfo const&)' Created attachment 193165 [details]
run EWS
Created attachment 193176 [details]
patch v2
fix build: do not exclude BackingStoreCairo.cpp from cmake.
Comment on attachment 193176 [details]
patch v2
r=me (largely taking in consideration Kenneth's approval).
Great! Comment on attachment 193176 [details] patch v2 Clearing flags on attachment: 193176 Committed r145880: <http://trac.webkit.org/changeset/145880> All reviewed patches have been landed. Closing bug. |