| Summary: | Threaded HTML Parser is missing feature define flags in all but Chromium port's build files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | Page Loading | Assignee: | Ryosuke Niwa <rniwa> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, abecsi, benjamin, dbates, dglazkov, eric, gyuyoung.kim, philn, rakuco, vestbo, webkit-ews, webkit.review.bot, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2013-03-13 12:46:16 PDT
Created attachment 192967 [details]
Adds the feature flag everywhere
Comment on attachment 192967 [details] Adds the feature flag everywhere Attachment 192967 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17147211 Comment on attachment 192967 [details] Adds the feature flag everywhere Attachment 192967 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17179101 Created attachment 192973 [details]
Fixed a type in FeatureList.pm
Comment on attachment 192973 [details] Fixed a type in FeatureList.pm View in context: https://bugs.webkit.org/attachment.cgi?id=192973&action=review > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:392 > PerformEnvironmentSet="true" Do you intend to enable it by default? Thanks! (In reply to comment #5) > (From update of attachment 192973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192973&action=review > > > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:392 > > PerformEnvironmentSet="true" > > Do you intend to enable it by default? I thought this flag just says to put this flag as an environmental variable? Oh, could be. I don't use visual studio much. Committed r145768: <http://trac.webkit.org/changeset/145768> |