| Summary: | [GTK] Missing atk in install-dependencies script | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gustavo, mrobinson, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Claudio Saavedra
2013-03-13 11:15:35 PDT
Created attachment 192950 [details]
Patch
(In reply to comment #1) > Created an attachment (id=192950) [details] > Patch The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests. (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=192950) [details] [details] > > Patch > > The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests. I think jhbuild has a mechanism to suggest installing packages from the distro. As it is now you can't use update-webkitgtk-libs to bootstrap webkit. Comment on attachment 192950 [details]
Patch
atk should go into install-dependencies instead of here. Only dependencies that require an exact version for layout tests to pass should go into the jhbuild moduleset.
Created attachment 194252 [details]
Patch
Comment on attachment 194252 [details] Patch Clearing flags on attachment: 194252 Committed r146472: <http://trac.webkit.org/changeset/146472> All reviewed patches have been landed. Closing bug. |