Bug 112272

Summary: [GTK] Missing atk in install-dependencies script
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Claudio Saavedra
Reported 2013-03-13 11:15:35 PDT
[GTK] Missing atk dependency for gtk in jhbuild moduleset
Attachments
Patch (2.53 KB, patch)
2013-03-13 11:16 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Patch (1.25 KB, patch)
2013-03-21 06:53 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2013-03-13 11:16:36 PDT
Created attachment 192950 [details] Patch
Martin Robinson
Comment 2 2013-03-13 11:45:51 PDT
(In reply to comment #1) > Created an attachment (id=192950) [details] > Patch The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests.
Claudio Saavedra
Comment 3 2013-03-13 11:51:36 PDT
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=192950) [details] [details] > > Patch > > The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests. I think jhbuild has a mechanism to suggest installing packages from the distro. As it is now you can't use update-webkitgtk-libs to bootstrap webkit.
Martin Robinson
Comment 4 2013-03-13 13:02:23 PDT
Comment on attachment 192950 [details] Patch atk should go into install-dependencies instead of here. Only dependencies that require an exact version for layout tests to pass should go into the jhbuild moduleset.
Claudio Saavedra
Comment 5 2013-03-21 06:53:59 PDT
Created attachment 194252 [details] Patch
WebKit Review Bot
Comment 6 2013-03-21 08:32:10 PDT
Comment on attachment 194252 [details] Patch Clearing flags on attachment: 194252 Committed r146472: <http://trac.webkit.org/changeset/146472>
WebKit Review Bot
Comment 7 2013-03-21 08:32:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.