Bug 112271

Summary:

Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, thorton, timothy, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Antoine Quint 2013-03-13 11:09:28 PDT

Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation

Comment 1 Antoine Quint 2013-03-13 11:13:45 PDT

Created attachment 192949 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2013-03-13 11:14:25 PDT

<rdar://problem/13412044>

Comment 3 Tim Horton 2013-03-13 11:16:47 PDT

Comment on attachment 192949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review

> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158
> +    m_fadeAnimationTimer.stop();

Should you reset m_fractionFadedIn to ... something?

Comment 4 Antoine Quint 2013-03-13 11:19:37 PDT

(In reply to comment #3)
> (From update of attachment 192949 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158
> > +    m_fadeAnimationTimer.stop();
> 
> Should you reset m_fractionFadedIn to ... something?

m_fractionFadedIn needs to be reset to 1.0 I would say.

Comment 5 Antoine Quint 2013-03-13 11:25:05 PDT

Created attachment 192951 [details]
Patch for landing

Comment 6 WebKit Review Bot 2013-03-13 11:49:46 PDT

Comment on attachment 192951 [details]
Patch for landing

Clearing flags on attachment: 192951

Committed r145731: <http://trac.webkit.org/changeset/145731>

Comment 7 WebKit Review Bot 2013-03-13 11:49:49 PDT

All reviewed patches have been landed.  Closing bug.