Bug 112267

Summary: [GTK] Build fixes after 145552
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2013-03-13 09:22:04 PDT 
[GTK] Build fixes after 145552
Comment 1 Zan Dobersek 2013-03-13 09:25:07 PDT 
Created attachment 192935 [details]
Patch
Comment 2 Zan Dobersek 2013-03-13 09:26:38 PDT 
I apologize for letting these mistakes creeping into the patch in the first place, though I still can't wrap my head around how building with the gold linker actually worked (the issue was discovered when using the GNU linker).
Comment 3 Gustavo Noronha (kov) 2013-03-13 10:53:01 PDT 
Comment on attachment 192935 [details]
Patch

That happens to me all the time - things working with gold and not with the old ld, I think gold is less strict  about its checking of unresolved symbols, and I assume that is one of the reasons why it's faster.
Comment 4 Gustavo Noronha (kov) 2013-03-13 12:42:12 PDT 
Comment on attachment 192935 [details]
Patch

I'll take the liberty of doing cq+ since this is a build fix and people are popping up asking about the problem.
Comment 5 WebKit Review Bot 2013-03-13 12:48:25 PDT 
Comment on attachment 192935 [details]
Patch

Clearing flags on attachment: 192935

Committed r145738: <http://trac.webkit.org/changeset/145738>
Comment 6 WebKit Review Bot 2013-03-13 12:48:28 PDT 
All reviewed patches have been landed.  Closing bug.