Bug 112255

Summary:

[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing

Product:

WebKit

Reporter:

Arvid Nilsson <anilsson>

Component:

WebKit BlackBerry

Assignee:

Arvid Nilsson <anilsson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

anilsson, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yodai

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

112236

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Arvid Nilsson

Reported 2013-03-13 07:10:39 PDT

Add a new WebOverlay method to expose the LayerCompositingThread::drawRect(). The patch for this bug partly overlaps with the patch for https://bugs.webkit.org/show_bug.cgi?id=112236, bug whichever one lands last will have to adapt I guess.

Attachments
Patch (8.13 KB, patch) 2013-03-13 07:22 PDT, Arvid Nilsson	no flags	Details Formatted Diff Diff
Patch (8.21 KB, patch) 2013-03-13 07:27 PDT, Arvid Nilsson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Arvid Nilsson

Comment 1 2013-03-13 07:11:51 PDT

Actually, the way the diff turned out, ideally https://bugs.webkit.org/show_bug.cgi?id=112236 should be landed first, to make public the toWebKitWindowCoordinates() method.

Arvid Nilsson

Comment 2 2013-03-13 07:22:27 PDT

Created attachment 192918 [details] Patch

Arvid Nilsson

Comment 3 2013-03-13 07:27:50 PDT

Created attachment 192919 [details] Patch

Arvid Nilsson

Comment 4 2013-03-13 07:29:04 PDT

(In reply to comment #3) > Created an attachment (id=192919) [details] > Patch I forgot to credit Yongxin as internal reviewer, in the first patch.

Jakob Petsovits

Comment 5 2013-03-13 09:12:52 PDT

Comment on attachment 192919 [details] Patch Very straightforward, looks good to me.