Bug 112252

Summary:

Web Inspector: get rid of hiddenPanels filter

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, graouts, gyuyoung.kim, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, timothy, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	vsevik: review+

Pavel Feldman

Reported 2013-03-13 06:07:10 PDT

Things are now filtered based on capabilities.

Attachments
Patch (21.75 KB, patch) 2013-03-13 06:10 PDT, Pavel Feldman	vsevik: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2013-03-13 06:10:08 PDT

Created attachment 192910 [details] Patch

Timothy Hatcher

Comment 2 2013-03-13 06:25:25 PDT

Comment on attachment 192910 [details] Patch FWIW, this was not added for compatibility reasons. It was added to give WebKit clients (non-browsers) control over what panels to show (hide). I don't think anyone has been using it for a while though, so it is fine to remove. We don't honor it in Safari's Web Inspector either.

Pavel Feldman

Comment 3 2013-03-13 06:37:57 PDT

I actually added it back in 2009 with your blessing :) Since then we upstreamed our work and aligned things. I meant to say that similar things (timeline, etc.) should be controlled using capabilities.

Pavel Feldman

Comment 4 2013-03-13 07:20:00 PDT

Committed r145717: <http://trac.webkit.org/changeset/145717>

Note You need to log in before you can comment on or make changes to this bug.