Bug 112249 – [WK2][Qt] Remove direct references to WK2 internals from QtWebPagePolicyClient.

• Component: New Bugs
• Status: RESOLVED INVALID

[Michael Brüning]

[WK2][Qt] Remove direct references to WK2 internals from QtWebPagePolicyClient.

[Michael Brüning]

Created attachment 192903 [details]
Patch

[Simon Hausmann]

Comment on attachment 192903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192903&action=review

> Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp:137
> +    QString mimeType = adoptToQString(WKURLResponseCopyMIMEType(response)).toLower();
> +    bool canShowMIMEType = WKFrameCanShowMIMEType(frame, adoptWK(WKStringCreateWithQString(mimeType)).get());

Hm, so this creates an intermediate QString just in order to call lower. I wonder if it would be better to make WKFrameCanShowMIMEType do the makeLower() inside and then allow us to pass the WKStringRef and avoid the QString conversion?

[Michael Brüning]

I checked and it seems that if we want to do fix this for good, we should do it in MIMETypeRegistry in WebCore.

[Anders Carlsson]

Comment on attachment 192903 [details]
Patch

Qt has been removed, clearing review flags.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.