Bug 112210 – [Crash] Touch Events retargeting causes crashes on chrome on android.

• Component: UI Events
• Status: RESOLVED FIXED

[Hayato Ito]

The bug on chromium here:
http://code.google.com/p/chromium/issues/detail?id=181603 (This might be security-restricted).

The possible cause:
http://trac.webkit.org/changeset/144877

[Hayato Ito]

Created attachment 192835 [details]
Fix crashes.

[Dimitri Glazkov (Google)]

Comment on attachment 192835 [details]
Fix crashes.

View in context: https://bugs.webkit.org/attachment.cgi?id=192835&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests - no new functionality.

Don't we need a regression test for a crash?

[Hayato Ito]

Thank you for the review.

(In reply to comment #2)
> (From update of attachment 192835 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192835&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        No new tests - no new functionality.
> 
> Don't we need a regression test for a crash?

Yes, we should. But I could not reproduce it yet.

Could you see the http://code.google.com/p/chromium/issues/detail?id=181603
I added you to cc, so you can see the bug on chromium now and know the detail.

I think this patch does not make things worse. So let me land this.

[WebKit Review Bot]

Comment on attachment 192835 [details]
Fix crashes.

Clearing flags on attachment: 192835

Committed r145677: <http://trac.webkit.org/changeset/145677>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Hayato Ito]

For the record, as per discussion on http://code.google.com/p/chromium/issues/detail?id=181603, this patch fixes the crash.

Tough, I am not sure yet why touches(), targetTouches() or changedTouches() will becomes null.
Let me repro that, and hopefully add a regression test in another patch.