Bug 112206

Summary: Primary plugin hit detection needs to run after plugin creation
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Dean Jackson
Reported 2013-03-12 16:28:55 PDT
We can't always guarantee that the didFinishLoad will happen before the plugins are created. Move the plugin hit detection to a more reliable spot.
Attachments
Patch (3.80 KB, patch)
2013-03-12 17:12 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-03-12 16:29:13 PDT
<rdar://problem/13405856>
Tim Horton
Comment 2 2013-03-12 16:29:35 PDT
Let's not move it, let's just call it from more than one place.
Tim Horton
Comment 3 2013-03-12 16:30:33 PDT
(it was designed to allow calling it again later (the plan was on-plugin-creation), and will choose a primary snapshotted plugin then if there isn't already one)
Dean Jackson
Comment 4 2013-03-12 17:12:30 PDT
Created attachment 192838 [details] Patch
Dean Jackson
Comment 5 2013-03-12 18:01:34 PDT
Committed r145644: <http://trac.webkit.org/changeset/145644>
Note You need to log in before you can comment on or make changes to this bug.