Bug 112198

Summary: Add a --build-directory argument to delete-stale-build-files
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch rniwa: review+

Tim Horton
Reported 2013-03-12 15:20:07 PDT
So that unconventional build setups can tell it where to look for build products.
Attachments
patch (1.59 KB, patch)
2013-03-12 15:22 PDT, Tim Horton 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-03-12 15:22:29 PDT
Created attachment 192824 [details] patch
Ryosuke Niwa
Comment 2 2013-03-12 15:29:06 PDT
Comment on attachment 192824 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=192824&action=review > Tools/BuildSlaveSupport/delete-stale-build-files:35 > + parser.add_option("--build-dir", dest="directory") Could you instead use --build-directory to match run-webkit-tests? > Tools/BuildSlaveSupport/delete-stale-build-files:53 > + directory = options.directory I would have preferred to call this buildDirectory. If you rename the option and omit "dest", it'll automatically do that.
Tim Horton
Comment 3 2013-03-12 15:41:07 PDT
http://trac.webkit.org/changeset/145600
Note You need to log in before you can comment on or make changes to this bug.