Bug 112178

Summary:

Make CheckedArithmetic slightly more sane

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Oliver Hunt 2013-03-12 12:46:32 PDT

Make CheckedArithmetic slightly more sane

Comment 1 Oliver Hunt 2013-03-12 12:49:15 PDT

Created attachment 192789 [details]
Patch

Comment 2 Geoffrey Garen 2013-03-12 12:54:54 PDT

Comment on attachment 192789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192789&action=review

r=me

> Source/WTF/wtf/CheckedArithmetic.h:73
> +    HasOverflowed,
> +    Safe

I think this would be clearer if the two states were called "DidOverflow" and "DidNotOverflow". Whether something is "safe" is a value judgement this data cannot make.

Comment 3 Oliver Hunt 2013-03-12 14:07:48 PDT

Committed r145580: <http://trac.webkit.org/changeset/145580>