Bug 112174 – XHTML MP 1.1 and 1.2 give errors for entities

• Component: XML
• Status: RESOLVED FIXED

[Liam Quinn]

When an XHTML Mobile Profile 1.1 or 1.2 document contains an XHTML entity such as © or  , WebKit's XML parser gives an error. When an XHTML Mobile Profile 1.0 document does the same thing, it works as expected.

The XML parser has a list of public doctypes for which it resolves XHTML entities. This list includes XHTML MP 1.0 but not XHTML MP 1.1 or 1.2. We should treat XHTML MP 1.1 and 1.2 the same as 1.0 in this respect.

[Liam Quinn]

Created attachment 192782 [details]
Patch

[Rob Buis]

Comment on attachment 192782 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 192782 [details]
Patch

Clearing flags on attachment: 192782

Committed r145744: <http://trac.webkit.org/changeset/145744>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

Comment on attachment 192782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192782&action=review

> Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:644
> +        || (publicId == QLatin1String("-//WAPFORUM//DTD XHTML Mobile 1.0//EN")
> +        || (publicId == QLatin1String("-//WAPFORUM//DTD XHTML Mobile 1.1//EN")

This part broke the Qt build. The line starts with an opening parentheses, the next opening parentheses is the one after QLatin1String but then there's only one closing parentheses.

[Simon Hausmann]

Prospective fix landed in http://trac.webkit.org/changeset/145756 - hope it works

[Liam Quinn]

(In reply to comment #6)
> Prospective fix landed in http://trac.webkit.org/changeset/145756 - hope it works

Thanks Simon--that change looks fine. I'm sorry for breaking the build.